-
Notifications
You must be signed in to change notification settings - Fork 0
Configure to use unresolved refcats (see DM-49289) #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| config: | ||
| # Alert distribution only runnable in PP environment. | ||
| alertPackager.doProduceAlerts: True | ||
| config.astrometry.referenceSelector.doUnresolved: False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the leading config. necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree that the leading config. should not be there, but more importantly this is a config for calibrateImage not diaPipe. So to set this you would need to exclude calibrateImage from ApPipe.yaml above and redefine it here, along with all of it's custom connections and configs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Major change: the config is for calibrateImage not diaPipe
| config: | ||
| # Alert distribution only runnable in PP environment. | ||
| alertPackager.doProduceAlerts: True | ||
| config.astrometry.referenceSelector.doUnresolved: False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree that the leading config. should not be there, but more importantly this is a config for calibrateImage not diaPipe. So to set this you would need to exclude calibrateImage from ApPipe.yaml above and redefine it here, along with all of it's custom connections and configs.
|
Is this PR still relevant? I thought it was a workaround for Pipelines issues. |
|
Is this still relevant? |
No description provided.