Introduce Rust guide

index.rst

@@ -16,7 +16,7 @@ Check out the `README <https://github.com/lsst-dm/dm_dev_guide/blob/main/README.
 
 **Jump to:** :ref:`Team <part-team>` · :ref:`Communications <part-communications>` · :ref:`Project documentation <part-project-docs>` · :ref:`Work management <part-work>`
 
-**Development guides:** :ref:`Overview <part-guides>` · :ref:`C++ <part-cpp>` · :ref:`Python <part-python>` · :ref:`Pybind11 <part-pybind11>` · :ref:`JavaScript <part-javascript>` · :ref:`ReStructuredText <part-rst>` · :ref:`DM Stack <part-dm-stack>` · :ref:`Git <part-git>` · :ref:`Editors <part-editors>` · :ref:`Legal <part-legal>` · :ref:`User documentation style <part-user-doc-style-guide>`
+**Development guides:** :ref:`Overview <part-guides>` · :ref:`C++ <part-cpp>` · :ref:`Rust <part-rust>` · :ref:`Python <part-python>` · :ref:`Pybind11 <part-pybind11>` · :ref:`JavaScript <part-javascript>` · :ref:`ReStructuredText <part-rst>` · :ref:`DM Stack <part-dm-stack>` · :ref:`Git <part-git>` · :ref:`Editors <part-editors>` · :ref:`Legal <part-legal>` · :ref:`User documentation style <part-user-doc-style-guide>`
 
 **Services:** :ref:`Overview <part-services>` · :ref:`Jenkins <part-jenkins>`
 
@@ -214,6 +214,24 @@ C++
 - :doc:`cpp/profiling`
 - :doc:`cpp/compilation-db`
 
+.. RUST SECTION ============================================================
+
+.. Hidden toctree to manage the sidebar navigation. Match the contents list below.
+
+.. toctree::
+   :maxdepth: 1
+   :caption: Rust
+   :hidden:
+
+   rust/rust
+
+.. _part-rust:
+
+rust
+----
+- :doc:`rust/rust`
+
+
 .. PYTHON SECTION ============================================================
 
 .. Hidden toctree to manage the sidebar navigation. Match the contents list below.

rust/rust.rst

@@ -0,0 +1,106 @@
+LSST Rust Development Guide
+===========================
+
+1. Introduction
+---------------
+
+This guide details the standards and best practices for writing Rust code within the LSST DM Stack and includes basic knowledge of the package.
+Rust is being adopted to provide performance-critical components and leverage its memory safety features.
+This document assumes a basic understanding of Rust and the LSST DM Stack.
+
+The de-facto location, and reference implementation, of rust within the lsst science pipelines is in a package called ``rubinoxide``.
+This does not mean developers are not allowed to use rust in another dedicated package, but unless there is a compelling reason to do so rust code should be placed in ``rubinoxide``.
+This guide assumes the package layout of ``rubinoxide``.
+Any other Rust based packages that are written should adhear to this as best as possible.
+
+2. Rust Version
+---------------
+
+All LSST Rust code must be compatible with the standard Rust toolchain provided in the rubin-env conda environment.
+
+3. Resources
+------------
+
+* The `Rust Book <https://doc.rust-lang.org/book/>`_  is a good resource to find out information on the rust language.  
+* `crates.io <https://crates.io/>`_ is where third party crates (libraries) are stored and distributed.
+  This contains links to the documentation on each crate.  
+* Likewise the python/rust build system can be found at `maturin <https://www.maturin.rs/>`_
+* Documentation for the python binding engine PyO3 can be found `here <https://docs.rs/pyo3/latest/pyo3/>`_
+
+4. Code Organization
+--------------------
+
+Unlike the package-centric organization often seen in Python, packages containing rust code should me monolithic and not depend on other lsst packages. 
+* Top-Level Module: All Rust code will be bound to a single top-level module.
+  This module will serve as the entry point for Python interaction.
+* Functional Modules: Within this top-level module, create sub-modules representing distinct functionalities (e.g., image processing, coordinate transformations, data structures).
+* Avoid Package-Specific Structure: Do not mirror the Python package structure in your Rust organization.
+  Focus on logical groupings of functionality.
+
+5. Python Interoperability
+--------------------------
+
+All Rust code intended for use within the LSST DM Stack must be exposed to Python via a well-defined API. This is achieved using the `pyO3`_ bindings.  
+* `pyO3`_ is Mandatory: `pyO3`_ is the only supported mechanism for exposing Rust functionality to Python.  
+* API Design: Rust-implemented Python functions and types should adhere to Python interface best practices instead of maximizing similarity to other internal Rust interfaces.
+* Documentation: Thoroughly document your Python API using docstrings. Docstrings are written as doc comments in the rust and are automatically translated to python docstrings by pyO3. Doc strings should be written in the same numpydoc format as specified in the python section of the devguide.
+
+6. Dependencies
+---------------
+
+Managing dependencies is crucial for maintaining a stable and reproducible build environment.  
+* RFC Process: All new Rust dependencies added to the Cargo.toml file must be approved via the LSST RFC (Request for Comments) process.
+  This ensures that dependencies are vetted for licensing, security, and long-term maintainability.  
+* Dependency Versions: Pin dependency versions in Cargo.toml to ensure reproducible builds with exact pins.  
+  As the Cargo.lock file is also committed to git, this ensures all builds remain on equal footing.
+  Incrementing version should be done on a standalone commit after evaluating the effect on compiling and packaging.
+
+7. Testing
+----------
+
+* Python Unit Tests: All Rust code with a Python interface must be tested via Python unit tests.
+  This provides a consistent testing framework and leverages the existing LSST testing infrastructure.
+  These tests should be placed in the **tests** top level directory.
+* pytest: Use pytest as the python testing framework.  
+* For functionality that does not have a public python api, or is not well covered by a python api, or is difficult to appropriately test with a python unit test rust unit tests may be written using the standard rust unit test infrastructure.
+  Genreally avoid a rust until test on any code that is wrapped with pyo3.
+* Import Rust Modules: Python tests should import the Rust modules (exposed via `pyO3`_) and exercise their functionality.  
+* Comprehensive Coverage: Strive for high test coverage to ensure that all critical code paths are tested.  
+* Integration Tests: In addition to unit tests, consider integration tests to verify the interaction between Rust components and other parts of the LSST DM Stack.
+
+8. Code Style and Formatting
+----------------------------
+
+Consistent code style improves readability and maintainability.  
+
+* `rustfmt`_: Use rustfmt to automatically format your Rust code.  
+* `Clippy`_: Use Clippy to lint your Rust code and identify potential issues.  
+* Documentation Comments: Write clear and concise documentation comments for all public functions and data structures.  
+* To the extent possible, make apis that will be public to python feel exactly as if they are written in python.
+
+9. Logging
+-----------
+
+Logging should be done using the `log`_ crate, and accompanying macros.
+The standard rubinoxide package initializes the pyo3_log crate to forward all logs through to the python log handler to the approprate log level.
+
+10. Don'ts
+----------
+
+* Do not use implicit multithreading in rust  
+* Do not introduce any cross package rust bindings that transit through python aka how we use c++ now.  
+* As mentioned above, do not arange module structure according to lsst packages. Write modules by related functionality.
+
+11. Build and management system integration
+-------------------------------------------
+
+* Rust packages should be built using maturin, which manages the complexities of compiling and bundling cargo products.  
+* Cargo additionally is to be used manage dependencies and run rust level tests.  
+* pip is used as the mechanism to locally depoly the wheels created by maturin  
+* pytest is used to run python level unit tests  
+* coordinating these scripts for the developer is a Makefile
+
+.. _rustfmt: https://github.com/rust-lang/rustfmt  
+.. _Clippy: https://github.com/rust-lang/rust-clippy
+.. _pyO3: https://pyo3.rs/
+.. _log: https://docs.rs/log/latest/log/