Feedback: general

[lppedd]

Feel free to write down whatever you want regarding the plugin, good and bad things you noticed using it, things you would like to see implemented or enhanced.

[Gerrit-K]

First of all thanks for all the effort in making this an even better plugin!

One suggestion I would like to propose: autosuggested scopes based on git history.

Background/details:
Our team started to use the conventional commit structure, but it's currently more of a guideline than a strict schema. In particular, we don't have fixed scopes, but everyone has a gist (and probably a personal opinion) on what to include as a scope in the parentheses. E.g. some commits reference a sub-path of the (mono)repo, like chore(python-app): something, some others might reference a (potentially cross-path) feature, like feat(feature-A): implemented new feature. For the reoccurring scopes (like in this case python-app) it would be useful to us if scopes would be autocompleted with all scopes that are already present in the git history.

I'd love to hear feedback on this idea. Cheers!

[lppedd]

@Gerrit-K Hi! Thanks a lot for the feedback 😄

One suggestion I would like to propose: autosuggested scopes based on git history.
...
For the reoccurring scopes (like in this case python-app) it would be useful to us if scopes would be autocompleted with all scopes that are already present in the git history.

This is similar to what I already do with the subject token.
If you look under the Providers settings you will notice the default provider is called Default - VCS.
This is because the subjects are extracted from the most-recent commit messages.
This isn't always accurate and I still have to understand how the Platform updates those "recent messages", so months ago I arrived at the conclusion that this kinda feature you proposed should be released as an Extension Provider (another plugin) which will look through the real VCS history.

This is absolutely a good idea that I will consider developing in the next month. I'm a bit busy now trying to create a real language (with an AST) for conventional commits.

[lppedd]

@Gerrit-K just a question: should the history-proposed scopes be extracted based on the inputted type, or would you like to see all of them anyway?

[Gerrit-K]

@lppedd thanks for the swift reply!

This is similar to what I already do with the subject token.

Yes, exactly that, but for scopes. Totally forgot about checking the settings 🙈 Seeing this now, I actually don't know if we really need the full history or if the recent history would suffice too. Would have to experiment with that. If it makes things easier, feel free to start with the latter, if you like.

should the history-proposed scopes be extracted based on the inputted type, or would you like to see all of them anyway?

For us I think it would make more sense to see all, because we usually perform different types on the same scope (e.g. fix(python-app), chore(python-app), feat(feature), refactor(feature)). But that might be just an opinion based on our way of committing, of course 😉

[lppedd]

@Gerrit-K the development for 0.17.0 is finished. It will be published tomorrow I think.

For whoever is reading, keep the suggestions coming 😄

[cn-src]

The type of non-English characters cannot be customized.

{
    "types": {
        "重构": {
            "description": "Changes which neither fix a bug nor add a feature"
        }
    }
}

[lppedd]

@cn-src oh wait, I don't understand 😅 Do you mean you cannot use non-ASCII characters in the custom JSON file?

[lppedd]

@cn-src yeah now I got it. The JSON Schema allows only a-zA-Z0-9-. You're right.

[ymind]

The type of non-English characters cannot be customized.

{
    "types": {
        "重构": {
            "description": "Changes which neither fix a bug nor add a feature"
        }
    }
}

建议保持简短的且标准的英文表述，后期处理时也更加方便、有规范。
It is recommended to keep a short and standard expression by English, it will be more convenient and standardized in post-processing.

可以参考我整理的常见提交类型:
You can refer to the common commit types here:
https://semantic-gitlog.github.io/semantic-gitlog/#/en-us/fundamentals/commit-types

[rluvaton]

Awesome plugin, one thing that prevents me from using it is the lack of GUI, I think it would be awesome if you would add something like VS Code - Conventional Commits Plugin

[agileago]

@lppedd maybe allow more other non-ASCII characters is better. i want to use chinese to show the commit type message