ot_kmac: Add clock hinting #172
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KMAC never actually provided clock hints to the clkmgr; implement some basic initial clock hinting for when the KMAC transitions into and out of the IDLE FSM state. Signed-off-by: Alex Jones <[email protected]>
This test was only failing because of the lack of KMAC clock hinting. Signed-off-by: Alex Jones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite the clkmgr connections being present, KMAC hasn't actually had clock hinting implemented, which was causing a failure in the
kmac_idle_test. Simply implement clock hinting on changes of FSM state.You can see the relevant RTL here. It reports idle to the clkmgr as long as the state is idle and the
msg_fifois empty - which will always be the case here as we have to be in theST_MSG_FEEDFSM state to allow data to be written to the input fifo, and we can only return toST_IDLEby either (a) a HW operation finishing, which doesn't use the input FIFO or (b) SW sends aDONEcommand after processing, where processing will empty the input fifo first.