Skip to content

Conversation

engdoreis
Copy link

No description provided.

@@ -55,6 +55,7 @@ system_ss.add(when: 'CONFIG_OT_SPI_HOST', if_true: files('ot_spi_host.c'))
system_ss.add(when: 'CONFIG_OT_SRAM_CTRL', if_true: files('ot_sram_ctrl.c'))
system_ss.add(when: 'CONFIG_OT_TIMER', if_true: files('ot_timer.c'))
system_ss.add(when: 'CONFIG_OT_UART', if_true: files('ot_uart.c'))
system_ss.add(when: 'CONFIG_OT_UART', if_true: files('ot_usbdev.c'))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy/paste

@@ -98,6 +98,7 @@ config OT_EARLGREY
select OT_SRAM_CTRL
select OT_TIMER
select OT_UART
select OT_USBDEV

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe OT_USB_DEVICE for consistency with OT_SPI_DEVICE (as well in filenames and symbols)?

@@ -0,0 +1,650 @@

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing header

CharBackend chr;
};

static void usbdev_update_irqs(OtUSBDEVState *s)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing ot_ prefix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants