chore: update docker image in setup.sh #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioestradarosa
approved these changes
Oct 17, 2021
marioestradarosa
left a comment
marioestradarosa
left a comment
There was a problem hiding this comment.
Great! thanks for the script upgrade @dhmlau
Signed-off-by: Diana Lau <[email protected]>
Member
Author
|
Verified locally. Will set up GitHub Actions as next step. Force merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Diana Lau [email protected]
When trying to set up the local environment to run the tests, I realized that the docker image specified in
setup.shno longer exist, it should be https://hub.docker.com/_/microsoft-mssql-server.cc @marioestradarosa
Checklist
npm testpasses on your machine