Skip to content

Conversation

@jannyHou
Copy link
Contributor

@jannyHou jannyHou commented May 7, 2020

Node 8 has reached end of life. This PR drops support for it.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@jannyHou jannyHou requested review from dhmlau and emonddr as code owners May 7, 2020 19:35
@jannyHou jannyHou mentioned this pull request May 7, 2020
Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please publish a semver-major version when publishing a new release. Thanks.

@jannyHou jannyHou merged commit 980b7e5 into master May 10, 2020
@delete-merged-branch delete-merged-branch bot deleted the drop-node-8 branch May 10, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants