fix: added missing 'ORDER BY' before 'OFFSET' II #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frbuceta
requested review from
b-admike,
dhmlau,
emonddr and
jannyHou
as code owners
4 tasks
achrinza
requested changes
Jan 20, 2020
raymondfeng
approved these changes
Jan 20, 2020
achrinza
approved these changes
Jan 20, 2020
Contributor
Author
|
ready for merge |
jannyHou
approved these changes
Jan 22, 2020
Contributor
jannyHou
left a comment
jannyHou
left a comment
There was a problem hiding this comment.
Thank you for the contribution! LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the supportsOffsetFetch is enabled, the generated SQL query is invalid as it does not comply with the expected syntax of a SELECT - ORDER BY Clause.
This PR resolves this issue by prepending the missing ORDER BY to OFFSET.
This PR was originally created by @achrinza
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machine