meal_days, meal_week update for dev; for when PR 2163 is merged into dev #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Prepare for the next update of LoopWorkspace dev for which meal_days and meal_week need a special dev version.
This same version will be used when Loop 3.6.0 is released
Background
There is a PR pending for LoopWorkspace: PR 246 that will, among other things, bring in a fix to code that is included in the original meal_days and meal_week patches.
When that PR is merged to dev, this PR for customization needs to be already merged.
The dev version of the patches are modified with respect to the main patches by removing the Loop PR 2163 bugfix from the patches.
Testing
This was tested with my local clone used to generate LoopWorkspace PR 246.
Test with
mainThe patches suitable to be used with LoopWorkspace
mainbranch are renamed to start with 01, so they are tested first and thus applied to main. Otherwise, the dev patch would be chosen and that does not have the PR 2163 fix.Test with
update_submodulesUntil such time as LoopWorkspace PR 246 is merged, use the LoopWorkspace
update_submodulesbranch to confirm the customizations work.Comments
Be aware that the customization select code can't tell the difference between the bolus_progress fix already merged into dev so will report that it is applied.