Add pump battery level option to Info Display and alarm #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add pumpBattery case to InfoType enum with "Pump Battery" display name - Add pumpBatteryLevel to Observable shared storage for quick access - Parse pump.battery.percent from Nightscout API device status - Display pump battery as percentage in Information Display table - Keep existing phone battery display unchanged Follows Nightscout naming conventions and existing code patterns with minimal changes to the codebase. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…11CUSK3fJJhZ55exs46iBrg Add pump battery level to Information Display table
This commit adds a new alarm type that triggers when the pump battery level drops below a user-configurable threshold. The implementation follows the existing battery alarm pattern to minimize new code. Changes: - Add .pumpBattery case to AlarmType enum - Create PumpBatteryCondition evaluator following BatteryCondition pattern - Create PumpBatteryAlarmEditor UI with threshold stepper (0-100%) - Add latestPumpBattery field to AlarmData - Update AlarmTask to pass pump battery data from Observable - Register PumpBatteryCondition in AlarmManager - Add routing to PumpBatteryAlarmEditor in AlarmEditor - Set default threshold to 20% with hour-based snooze - Categorize as device alarm with battery icon and "Pump battery low" description - Register files in Xcode project build system The pump battery data is available via Observable.shared.pumpBatteryLevel from the recent pump battery info display feature. This alarm reuses all existing alarm infrastructure. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…UyFC6TU6Rs9Up34HJ7J Add pump battery alarm with configurable threshold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pump battery level option to Info Display and Alarms: