Skip to content

Conversation

@jeremytchang
Copy link
Collaborator

  • Added yarn bundle step to make sure hackathon can always be bundled
  • Renamed and split up steps to be more descriptive

Copy link

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this may run on every PR as written. See the other workflow files for how they limit the scope of CI to the affected paths.

@jeremytchang
Copy link
Collaborator Author

jeremytchang commented Dec 16, 2021

@jkaster This workflow should only run on wholly-sheet and hackathon path only. Unless i'm misunderstanding this on section this existing workflow should be limited in scope already.

Also if scope wasn't limited, the checks for this PR would have run the Hackathon CI too, but it has not.

@jeremytchang
Copy link
Collaborator Author

Also this is only adding steps to the original hackathon CI workflow Bryan and you approved/merged before.

Copy link

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drstrangelooker drstrangelooker force-pushed the main branch 4 times, most recently from 9474788 to 5f9930c Compare February 4, 2022 02:33
@drstrangelooker drstrangelooker merged commit da01692 into main Feb 15, 2022
@drstrangelooker drstrangelooker deleted the jc/hackathon_ci branch February 15, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants