Skip to content

Conversation

@mxhob1
Copy link

@mxhob1 mxhob1 commented Apr 22, 2016

Updated the TZ regex to allow detection of Australian Eastern Standard Time (UTC+10)

@l33t0
Copy link

l33t0 commented Apr 22, 2016

+1

@ph
Copy link
Contributor

ph commented Apr 26, 2016

@mxhob1 Would you mind doing step 2 of the contributing guide? https://github.com/elasticsearch/logstash/blob/master/CONTRIBUTING.md#contribution-steps

Also should we keep PMCE ?

@ph ph added the missing cla label Apr 26, 2016
@mxhob1
Copy link
Author

mxhob1 commented Apr 26, 2016

@ph I had signed the CLA after posting the PR, can you recheck?

The updated regex will cater for the previous criteria

@markwalkom
Copy link

LGTM (for whatever it is worth ;)

@ph
Copy link
Contributor

ph commented Apr 27, 2016

@mxhob1 did you use the same email when signing up that we see the patch file ?
https://patch-diff.githubusercontent.com/raw/logstash-plugins/logstash-patterns-core/pull/148.patch

@mxhob1
Copy link
Author

mxhob1 commented Apr 27, 2016

@ph Ah, that is an old email address. It was signed under [email protected] with my Github username. Rectified on my side.

@karmi
Copy link

karmi commented Apr 28, 2016

Hi Michael, can you please add both of the e-mails to your Github profile? This should work on our side, to properly match you against Github username. If you don't have access to the old e-mail anymore, would it be possible to just commit it with the new one, and force push?

git commit --verbose --author="John Smith <[email protected]>" --amend
git push --force

@karmi
Copy link

karmi commented May 11, 2016

Hi @mxhob1, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@mxhob1
Copy link
Author

mxhob1 commented May 11, 2016

@karmi: I have re-committed with the new email as I don't have access to the old one and all checks seem to have passed this time

@elasticsearch-bot
Copy link

Andrew Cholakian merged this into the following branches!

Branch Commits
master ad4947d, b1825be, ce605d6, f53afa5, cb27df2

elasticsearch-bot pushed a commit that referenced this pull request May 17, 2016
elasticsearch-bot pushed a commit that referenced this pull request May 17, 2016
elasticsearch-bot pushed a commit that referenced this pull request May 17, 2016
elasticsearch-bot pushed a commit that referenced this pull request May 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants