-
Notifications
You must be signed in to change notification settings - Fork 974
Modify TZ to allow AEST #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
+1 |
|
@mxhob1 Would you mind doing step 2 of the contributing guide? https://github.com/elasticsearch/logstash/blob/master/CONTRIBUTING.md#contribution-steps Also should we keep |
|
@ph I had signed the CLA after posting the PR, can you recheck? The updated regex will cater for the previous criteria |
|
LGTM (for whatever it is worth ;) |
|
@mxhob1 did you use the same email when signing up that we see the patch file ? |
|
@ph Ah, that is an old email address. It was signed under [email protected] with my Github username. Rectified on my side. |
|
Hi Michael, can you please add both of the e-mails to your Github profile? This should work on our side, to properly match you against Github username. If you don't have access to the old e-mail anymore, would it be possible to just commit it with the new one, and force push? git commit --verbose --author="John Smith <[email protected]>" --amend
git push --force |
|
@karmi: I have re-committed with the new email as I don't have access to the old one and all checks seem to have passed this time |
Updated the TZ regex to allow detection of Australian Eastern Standard Time (UTC+10)