Add ampersand to URIPATH #114
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
|
please jenkins, test this. |
|
@elyscape thanks a lot for your contribution, are you so nice to extend the current test with a "check" for this improvement? this would be required before we can move forward. Let me know if you have problems with it, I'm open to provide help for sure! |
Contributor
Author
|
@purbon Updated. Sorry for the delay. |
This allows for validating that a pattern will fail to match an entire string, even if it would match partially.
RFC1738 specifies that URL paths can legally contain ampersands:
; HTTP
httpurl = "http://" hostport [ "/" hpath [ "?" search ]]
hpath = hsegment *[ "/" hsegment ]
hsegment = *[ uchar | ";" | ":" | "@" | "&" | "=" ]
search = *[ uchar | ";" | ":" | "@" | "&" | "=" ]
Accordingly, HAProxy (and potentially other applications) will not
escape them in log files.
Contributor
Author
|
Updated again with some tests for invalid matches. |
Contributor
Author
Contributor
|
LGTM |
elasticsearch-bot
pushed a commit
that referenced
this pull request
Mar 22, 2016
RFC1738 specifies that URL paths can legally contain ampersands:
; HTTP
httpurl = "http://" hostport [ "/" hpath [ "?" search ]]
hpath = hsegment *[ "/" hsegment ]
hsegment = *[ uchar | ";" | ":" | "@" | "&" | "=" ]
search = *[ uchar | ";" | ":" | "@" | "&" | "=" ]
Accordingly, HAProxy (and potentially other applications) will not
escape them in log files.
Fixes #114
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC1738 specifies that URL paths can legally contain ampersands:
Accordingly, HAProxy (and potentially other applications) will not escape them in log files.
Fixes #54.