-
Notifications
You must be signed in to change notification settings - Fork 974
COMMONAPACHELOG: match email address in auth field #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please add a test (or better yet, tests) to https://github.com/logstash-plugins/logstash-patterns-core/tree/master/spec/patterns to guarantee that usage will work as expected and not break other patterns. |
975fc87 to
9df7cb6
Compare
logstash-plugins#3 matches email addresses in the `ident` field. Also allow email addresses in the `auth` field.
|
@untergeek I've added a couple of tests for this change and for the change in #3. |
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
|
please jenkins, test this. |
spec/patterns/httpd_spec.rb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good additions to the test suites, I wonder if you could also add some that match the "former" USER pattern too? like this we'll be sure there are no regressions introduced.
|
@mattjbray thanks a lot for your contribution, I just left you a very small comment. As soon as we're good with it, I'm very welcome to merge this. Looking forward to it. |
|
@purbon I've added a test for matching the USER pattern in both fields. |
|
@mattjbray awesome, good job! |
|
please jenkins, test this. |
|
this has been fixed in #142, thanks for the contribution! |
#3 matches email addresses in the
identfield. Also allow email addresses in theauthfield.