Skip to content

Conversation

@jsvd
Copy link
Member

@jsvd jsvd commented Apr 24, 2025

Renew the certificates used for testing and facilitate their regeneration in the future.

@jsvd jsvd marked this pull request as ready for review April 24, 2025 15:07
Copy link
Contributor

@donoghuc donoghuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new rake task works for me locally. Couple failed cells in travis, looks like tests are expecting an ssl error but instead there is a connection refused. Could be transient or a brittle test.

@donoghuc
Copy link
Contributor

Tried a reload of the failed cells. 👀

@jsvd jsvd merged commit e322537 into logstash-plugins:main Apr 24, 2025
2 of 3 checks passed
@jsvd
Copy link
Member Author

jsvd commented Apr 24, 2025

I will improve the tests in the upcoming PR I have to fix a bug in the plugin

@jsvd jsvd deleted the modernize_certs branch April 24, 2025 15:58
jsvd added a commit to jsvd/logstash-output-tcp that referenced this pull request Apr 29, 2025
jsvd added a commit that referenced this pull request Apr 29, 2025
* renew certificates and add task to facilitate future regeneration (#60)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants