Skip to content

tolerate absence of certificate when enabling ssl #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2019
Merged

tolerate absence of certificate when enabling ssl #36

merged 1 commit into from
Jan 2, 2019

Conversation

@jsvd
Copy link
Member

@jsvd jsvd commented Jan 2, 2019

fixes #25
fixes #22

@elasticsearch-bot elasticsearch-bot self-assigned this Jan 2, 2019
yaauie
yaauie approved these changes Jan 2, 2019
View reviewed changes
Copy link
Contributor

@yaauie yaauie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@yaauie yaauie assigned yaauie and unassigned elasticsearch-bot Jan 2, 2019
@jsvd
Copy link
Member Author

jsvd commented Jan 2, 2019

Thanks @yaauie

@jsvd jsvd merged commit 54ce056 into logstash-plugins:master Jan 2, 2019
@jsvd jsvd deleted the conditional_ssl_setup branch January 2, 2019 19:57
@jockjiang
Copy link

Thanks @jsvd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaauie yaauie yaauie approved these changes

Assignees

@yaauie yaauie

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enabling ssl enforces use of ssl_key_passphrase enabling ssl enforces the use of ssl_cert with no error handling

4 participants

@jsvd @jockjiang @yaauie @elasticsearch-bot