Fix worker dying on upload exception and shutdown #80
Conversation
|
#79 |
|
CLA was signed, please let me know if something else needs to be done for CLA check to pass |
|
@ihorkhavkin thanks for the PR. Apologies for the extreme delay in looking at this, I'm taking a look now :) |
|
This mostly looks good to merge to me, but I want to hold off for a minute. It looks to me like nothing properly terminates the worker threads on shutdown. That seems problematic. The tests all pass but I want to do a manual test to see how that goes. I'm not sure if this is the PR to fix this in (probably not) but I want to think about it over the weekend. |
| rescue Exception => ex | ||
| @logger.error("failed to upload, will re-enqueue #{file} for upload", | ||
| :ex => ex, :backtrace => ex.backtrace) | ||
| unless file.nil? |
There was a problem hiding this comment.
The file cannot be nil, since we are dequeuing stuff.
There was a problem hiding this comment.
Actually, It could be nil when queue #deq get interrupted at shutdown.
There was a problem hiding this comment.
After discussing with @andrewvc we don't think this case happen in the JVM.
|
Merged in #90 |
3 participants
Fixes issue with upload stopping when
move_file_to_bucketfails and cleans up shutdown a bit (as case doesn't seem to work on class comparison - http://stackoverflow.com/a/5694333/5657104 )