Remove type when connecting to ES 7 and user doesn't specify it
#994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 18, 2021
jsvd
approved these changes
Feb 22, 2021
Member
jsvd
left a comment
jsvd
left a comment
There was a problem hiding this comment.
LGTM
I manually tested a few scenarios:
- plain
output { elasticsearch {}}: no deprecation logs, documents indexed with _doc output { elasticsearch { document_type => meh index => test }}: confirmed "meh
was used as the document type AND that ES logged a deprecation warningoutput { elasticsearch { index => test }}: confirmed that in the absence of type, documents were indexed with the index's type (in this case, "meh"). No deprecation log was emitted.
jsvd
reviewed
Feb 22, 2021
docs/index.asciidoc
Outdated
| When connected to Elasticsearch 7.x, modern versions of this plugin | ||
| use the required `_doc` document-type when inserting documents. | ||
| don't use the document-type when inserting documents, unless the user | ||
| ecplicitly sets <<plugins-{type}s-{plugin}-document_type>>. |
Member
There was a problem hiding this comment.
Suggested change
| ecplicitly sets <<plugins-{type}s-{plugin}-document_type>>. | |
| ecplicitly sets <<plugins-{type}s-{plugin}-document_type>>. |
Suggested change
| ecplicitly sets <<plugins-{type}s-{plugin}-document_type>>. | |
| explicitly sets <<plugins-{type}s-{plugin}-document_type>>. |
…is printed for each request (index/bulk) that contains the deprecated index _type. This commit removes the implicit set of type when connected to Elasticsearch 7.x unless the user doesn't specify explicitly the type. PR logstash-plugins#994 Fixes logstash-plugins#915
andsel
force-pushed
the
fix/avoid_to_send_type_when_connected_to_ES7
branch
from
7b54cd4 to
e5fd2d5
Compare
|
Andrea Selva merged this to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With ES 7.10.0 a deprecation log line about types removal is printed for each request (index/bulk) that contains the deprecated index
_type.This led to possible flood of deprecation logs on Elasticsearch, tracked in elastic/elasticsearch#69188.
This commit removes the implicit set of type when connected to ES7 unless the user doesn't specify explicitly the type.
Related to #915