Skip to content

Conversation

@yaauie
Copy link
Contributor

@yaauie yaauie commented Jun 30, 2022

Replaces #137, adding tests and docs

Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@roaksoax roaksoax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@yaauie yaauie merged commit 6ff00f0 into logstash-plugins:main Nov 7, 2022
| <<plugins-{type}s-{plugin}-query_template>> |<<string,string>>|No
| <<plugins-{type}s-{plugin}-result_size>> |<<number,number>>|No
| <<plugins-{type}s-{plugin}-retry_on_failure>> |<<number,number>>|No
| <<plugins-{type}s-{plugin}-result_on_status_>> |<<number,number list>>|No
Copy link
Contributor

@karenzone karenzone Feb 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this was supposed to be "retry_on_status"? There's also a random _ at the end of the entry , which is enough to fail docs-ci.
The extra space and list in entry causes failures, too.
:-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the ability to retry on failure.

4 participants