-
Notifications
You must be signed in to change notification settings - Fork 14
docs: new feature doc for openflow #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying localstack-docs with
|
Latest commit: |
0396d3e
|
Status: | ✅ Deploy successful! |
Preview URL: | https://f0c27b81.localstack-docs.pages.dev |
Branch Preview URL: | https://docs-snow-openflow-via-apach.localstack-docs.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor typo suggested but otherwise approved.
Co-authored-by: Przemek Denkiewicz <[email protected]> Co-authored-by: Brian Rinaldi <[email protected]>
![]() UI image included: https://b5ae2e50.localstack-docs.pages.dev/snowflake/features/openflow/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking further at the description of the Waldemar’s PR and the docs example here, in order to make the setup instructions a little easier to follow, I think we could potentially utilize the other screenshots listed in the PR as well 💭
I left placeholders on where we can place each screenshot, if we decide to go with it 🙌
Hola @gentris, here's the updated preview w/ the 5 images added: |
Also... tyvm @whummer for including screenshots in your PR description! They were super helpful because we were also able to add them to the docs 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for the super speedy work! 🚀🚀
I left one last comment regarding the last screenshot, and it should be good to go!🙌
We need to document a new feature that expose the Apache NiFi service and uses it for emulating OpenFlow functionality in Snowflake.