[MLIR][TORCH] Add support for enable_gqa flag in SDPA op
#3950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vivek Khandelwal <[email protected]>
vivekkhandelwal1
requested review from
AmosLewis,
pashu123,
rsuderman and
zjgarvey
pashu123
approved these changes
Jan 9, 2025
Member
pashu123
left a comment
pashu123
left a comment
There was a problem hiding this comment.
LGTM! Are there any reasons why we aren't decomposing this torch op into another set of torch ops?
Collaborator
Author
AFAIK, the reason for not doing that is since we want the attention op as a single kernel. Hence, we just lower it to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.