[MHLO] add VerifyMhloBackendContract #1321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanyokwok
force-pushed
the
tanyo/torch-mlir
branch
from
c09aee6 to
d3187ab
Compare
AmosLewis
pushed a commit
to AmosLewis/torch-mlir
that referenced
this pull request
Sep 2, 2022
* [MHLO] add VerifyMhloBackendContract * guard with macro
AmosLewis
pushed a commit
to AmosLewis/torch-mlir
that referenced
this pull request
Sep 2, 2022
* [MHLO] add VerifyMhloBackendContract * guard with macro
sjain-stanford
added a commit
that referenced
this pull request
Sep 7, 2022
The `-DTORCH_MLIR_ENABLE_MHLO` flag was recently introduced for `TorchMLIRTorchConversionPassesIncGen` [here](https://sourcegraph.com/github.com/llvm/torch-mlir@99093d0623c3d3e6fb961ad0c8fda5ee9fc264fe/-/blob/utils/bazel/torch-mlir-overlay/BUILD.bazel?L319) in [this recent PR](#1321) (was already present for `TorchMLIRConversionPassesIncGen` [here](https://sourcegraph.com/github.com/llvm/torch-mlir@99093d0623c3d3e6fb961ad0c8fda5ee9fc264fe/-/blob/utils/bazel/torch-mlir-overlay/BUILD.bazel?L288)). Before this PR, the MHLO sources in TorchConversion were not being built. This indicates a build issue that pre-existed but didn’t trigger until this path was enabled recently. Disabling to get the build green for now, until we can diagnose and fix the build for MHLO sources in TorchConversion.
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
* call zhigh-to-zlow from onnx-to-krnl and delete zhigh-to-zlow pass Signed-off-by: Tung D. Le <[email protected]> * call zlow-to-llvm from krnl-to-llvm and delete zlow-to-llvm pass Signed-off-by: Tung D. Le <[email protected]> * Hook for KrnlTypeConverter and add lit tests Signed-off-by: Tung D. Le <[email protected]> * undo redundant changes Signed-off-by: Tung D. Le <[email protected]> * small changes Signed-off-by: Tung D. Le <[email protected]> * Readd some passes Signed-off-by: Tung D. Le <[email protected]> * Address comments Signed-off-by: Tung D. Le <[email protected]> * Address comments Signed-off-by: Tung D. Le <[email protected]> * Clean up header includes and some functions Signed-off-by: Tung D. Le <[email protected]> * Edit comments Signed-off-by: Tung D. Le <[email protected]> * typos Signed-off-by: Tung D. Le <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1267