[ClangBuilder] Correct path of testsuite virtualenv's Python #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes 60d2141. On Windows, it's Scripts/python, on Linux it's bin/python. Unfortunately there is no third common path to use. Even the virtualenv docs have different paths for Windows and everything else: https://virtualenv.pypa.io/en/latest/user_guide.html#quick-start
omjavaid
approved these changes
Sep 2, 2025
Contributor
|
This looks good. I should have tested a linux worker as well. Thanks for fixing this. |
omjavaid
added a commit
that referenced
this pull request
Sep 4, 2025
vvereschaka
pushed a commit
to vvereschaka/llvm-zorg
that referenced
this pull request
Sep 25, 2025
Fixes 60d2141. On Windows, it's Scripts/python, on Linux it's bin/python. Unfortunately there is no third common path to use. Even the virtualenv docs have different paths for Windows and everything else: https://virtualenv.pypa.io/en/latest/user_guide.html#quick-start
vvereschaka
pushed a commit
to vvereschaka/llvm-zorg
that referenced
this pull request
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 60d2141.
On Windows, it's Scripts/python, on Linux it's bin/python.
Unfortunately there is no third common path to use. Even the virtualenv docs have different paths for Windows and everything else: https://virtualenv.pypa.io/en/latest/user_guide.html#quick-start