Skip to content

[CI] Remove Windows Server 2019 Runnerset #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 0 additions & 44 deletions premerge/gke_cluster/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -97,50 +97,6 @@ resource "google_container_node_pool" "llvm_premerge_libcxx" {
}
}

# TODO(boomanaiden154): Make sure to delete this node pool after we have
# switched over to server 2022.
resource "google_container_node_pool" "llvm_premerge_windows" {
name = "llvm-premerge-windows"
location = var.region
cluster = google_container_cluster.llvm_premerge.name
initial_node_count = 0

autoscaling {
total_min_node_count = 0
total_max_node_count = 16
}

# We do not set a taint for the windows nodes as kubernetes by default sets
# a node.kubernetes.io/os taint for windows nodes.
node_config {
machine_type = var.windows_machine_type
labels = {
"premerge-platform" : "windows"
}
image_type = "WINDOWS_LTSC_CONTAINERD"
# Add a script that runs on the initial boot to disable Windows Defender.
# Windows Defender causes an increase in test times by approximately an
# order of magnitude.
metadata = {
"sysprep-specialize-script-ps1" = "Set-MpPreference -DisableRealtimeMonitoring $true"
# Terraform wants to recreate the node pool everytime whe running
# terraform apply unless we explicitly set this.
# TODO(boomanaiden154): Look into why terraform is doing this so we do
# not need this hack.
"disable-legacy-endpoints" = "true"
}
disk_size_gb = 200
disk_type = "pd-ssd"
# Terraform wants to recreate the node pool everytime whe running
# terraform apply unless we explicitly set this.
# TODO(boomanaiden154): Look into why terraform is doing this so we do
# not need this hack.
resource_labels = {
"goog-gke-node-pool-provisioning-model" = "on-demand"
}
}
}

resource "google_container_node_pool" "llvm_premerge_windows_2022" {
name = "llvm-premerge-windows-2022"
location = var.region
Expand Down
41 changes: 0 additions & 41 deletions premerge/premerge_resources/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,6 @@ resource "kubernetes_namespace" "llvm_premerge_libcxx_next_runners" {
}
}

resource "kubernetes_namespace" "llvm_premerge_windows_runners" {
metadata {
name = "llvm-premerge-windows-runners"
}
}

resource "kubernetes_namespace" "llvm_premerge_windows_2022_runners" {
metadata {
name = "llvm-premerge-windows-2022-runners"
Expand Down Expand Up @@ -121,23 +115,6 @@ resource "kubernetes_secret" "libcxx_next_github_pat" {
depends_on = [kubernetes_namespace.llvm_premerge_libcxx_next_runners]
}

resource "kubernetes_secret" "windows_github_pat" {
metadata {
name = "github-token"
namespace = "llvm-premerge-windows-runners"
}

data = {
"github_app_id" = var.github_app_id
"github_app_installation_id" = var.github_app_installation_id
"github_app_private_key" = var.github_app_private_key
}

type = "Opaque"

depends_on = [kubernetes_namespace.llvm_premerge_windows_runners]
}

resource "kubernetes_secret" "windows_2022_github_pat" {
metadata {
name = "github-token"
Expand Down Expand Up @@ -185,24 +162,6 @@ resource "helm_release" "github_actions_runner_set_linux" {
]
}

resource "helm_release" "github_actions_runner_set_windows" {
name = "llvm-premerge-windows-runners"
namespace = "llvm-premerge-windows-runners"
repository = "oci://ghcr.io/actions/actions-runner-controller-charts"
version = "0.11.0"
chart = "gha-runner-scale-set"

values = [
"${templatefile("windows_runner_values.yaml", { runner_group_name : var.runner_group_name })}"
]

depends_on = [
kubernetes_namespace.llvm_premerge_windows_runners,
kubernetes_secret.windows_github_pat,
helm_release.github_actions_runner_controller,
]
}

resource "helm_release" "github_actions_runner_set_windows_2022" {
name = "llvm-premerge-windows-2022-runners"
namespace = "llvm-premerge-windows-2022-runners"
Expand Down
48 changes: 0 additions & 48 deletions premerge/windows_runner_values.yaml

This file was deleted.