[Flang] Enable libquadmath for AMDGPU flang bot #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplehr
requested review from
Meinersbur,
agozillon,
dpalermo,
gkistanova,
jhuber6 and
ronlieb
ronlieb
approved these changes
Jun 25, 2024
Contributor
Author
|
@dpalermo mentioned there is a build issue in libquadmath right now, I believe. So, I'll hold off with landing this patch until this is resolved. |
|
Need a fix to llvm/llvm-project#93519 before libquadmath can be enabled. |
dpalermo
approved these changes
Jul 12, 2024
dpalermo
left a comment
dpalermo
left a comment
There was a problem hiding this comment.
This change can now be merged whenever you are ready.
The build issue has been resolved by: llvm/llvm-project#98072
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.