Skip to content

Conversation

@keith
Copy link
Member

@keith keith commented Jul 22, 2024

Seems like this test was never running with cmake, but is running with
bazel and broke at head.

Seems like this test was never running with cmake, but is running with
bazel and broke at head.
@llvmbot
Copy link
Member

llvmbot commented Jul 22, 2024

@llvm/pr-subscribers-clang

Author: Keith Smiley (keith)

Changes

Seems like this test was never running with cmake, but is running with
bazel and broke at head.


Full diff: https://github.com/llvm/llvm-project/pull/99907.diff

2 Files Affected:

  • (modified) clang/unittests/Tooling/CMakeLists.txt (+1)
  • (modified) clang/unittests/Tooling/RecursiveASTVisitorTests/DeductionGuide.cpp (+1-1)
diff --git a/clang/unittests/Tooling/CMakeLists.txt b/clang/unittests/Tooling/CMakeLists.txt
index 0eb612f8d9498..401978c31863c 100644
--- a/clang/unittests/Tooling/CMakeLists.txt
+++ b/clang/unittests/Tooling/CMakeLists.txt
@@ -40,6 +40,7 @@ add_clang_unittest(ToolingTests
   RecursiveASTVisitorTests/CXXMethodDecl.cpp
   RecursiveASTVisitorTests/CXXOperatorCallExprTraverser.cpp
   RecursiveASTVisitorTests/DeclRefExpr.cpp
+  RecursiveASTVisitorTests/DeductionGuide.cpp
   RecursiveASTVisitorTests/ImplicitCtor.cpp
   RecursiveASTVisitorTests/ImplicitCtorInitializer.cpp
   RecursiveASTVisitorTests/InitListExprPostOrder.cpp
diff --git a/clang/unittests/Tooling/RecursiveASTVisitorTests/DeductionGuide.cpp b/clang/unittests/Tooling/RecursiveASTVisitorTests/DeductionGuide.cpp
index cd4bf0eb7bd5a..27cb39ea8fdf7 100644
--- a/clang/unittests/Tooling/RecursiveASTVisitorTests/DeductionGuide.cpp
+++ b/clang/unittests/Tooling/RecursiveASTVisitorTests/DeductionGuide.cpp
@@ -58,7 +58,7 @@ Bar s(1);
       DeductionGuideVisitor::Lang_CXX2a));
 }
 
-TEST(RecursiveASTVisitor, DeductionGuideImplicitMode) {
+TEST(RecursiveASTVisitor, DISABLED_DeductionGuideImplicitMode) {
   DeductionGuideVisitor Visitor(/*ShouldVisitImplicitCode*/ true);
   Visitor.ExpectMatch("Foo(T) -> Foo<int>", 11, 1);
   Visitor.ExpectMatch("Bar(type-parameter-0-0) -> Foo<int>", 14, 1);

Copy link
Collaborator

@hokein hokein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, good catch!

@keith keith merged commit 50c4e03 into llvm:main Jul 22, 2024
@keith keith deleted the ks/clang-test-add-missing-test-file-to-cmake branch July 22, 2024 18:49
yuxuanchen1997 pushed a commit that referenced this pull request Jul 25, 2024
Summary:
Seems like this test was never running with cmake, but is running with
bazel and broke at head.

Test Plan: 

Reviewers: 

Subscribers: 

Tasks: 

Tags: 


Differential Revision: https://phabricator.intern.facebook.com/D60251437
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang Clang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants