[clang] Add std::span to the default gsl pointer annotation list.
#99622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clang Author: Haojian Wu (hokein) ChangesFull diff: https://github.com/llvm/llvm-project/pull/99622.diff 1 Files Affected:
diff --git a/clang/lib/Sema/SemaAttr.cpp b/clang/lib/Sema/SemaAttr.cpp
index aaabd989c5c9f..5a7f12c7689d4 100644
--- a/clang/lib/Sema/SemaAttr.cpp
+++ b/clang/lib/Sema/SemaAttr.cpp
@@ -193,6 +193,7 @@ void Sema::inferGslOwnerPointerAttribute(CXXRecordDecl *Record) {
"basic_string_view",
"reference_wrapper",
"regex_iterator",
+ "span",
};
if (!Record->getIdentifier())
|
Collaborator
|
Hmm. Can/should we also make these const? |
Collaborator
Author
Yes, I will change them in a follow-up patch. |
hokein
added a commit
that referenced
this pull request
Jul 19, 2024
Address the comment in #99622 (comment)
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
…99622) Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60251408
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
Summary: Address the comment in #99622 (comment) Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60251273
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.