[Clang][AST] Don't use canonical type when checking dependence in Type::isOverloadable #98563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clang Author: Krystian Stasiowski (sdkrystian) ChangesFixes #97646. Still need to add tests. Full diff: https://github.com/llvm/llvm-project/pull/98563.diff 1 Files Affected:
diff --git a/clang/include/clang/AST/Type.h b/clang/include/clang/AST/Type.h
index a2194361abd53..8b236af78ea22 100644
--- a/clang/include/clang/AST/Type.h
+++ b/clang/include/clang/AST/Type.h
@@ -8438,7 +8438,7 @@ inline bool Type::isUndeducedType() const {
/// Determines whether this is a type for which one can define
/// an overloaded operator.
inline bool Type::isOverloadableType() const {
- if (!CanonicalType->isDependentType())
+ if (!isDependentType())
return isRecordType() || isEnumeralType();
return !isArrayType() && !isFunctionType() && !isAnyPointerType() &&
!isMemberPointerType();
|
sdkrystian
force-pushed
the
fix-is-overloadable
branch
2 times, most recently
from
e4ff4eb to
d60492d
Compare
cor3ntin
approved these changes
Jul 23, 2024
Contributor
cor3ntin
left a comment
cor3ntin
left a comment
There was a problem hiding this comment.
LGTM, modulo
- missing release note
- can you move the test in a GH97646 namespace and put it in
decltype.cpp,
or renametypeof_unqual.cppto typeof.cpp and put it there?
Maybe, while you are at it, add a test for __typeof_unqual
Thanks!
sdkrystian
force-pushed
the
fix-is-overloadable
branch
from
d60492d to
5036207
Compare
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
…e::isOverloadable (#98563) Summary: Fixes #97646. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60250645
ahatanaka
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Sep 17, 2024
…e::isOverloadable (llvm#98563) Fixes llvm#97646. Conflicts: clang/docs/ReleaseNotes.rst clang/test/SemaCXX/decltype.cpp
ahatanaka
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Sep 17, 2024
…e::isOverloadable (llvm#98563) Fixes llvm#97646. Conflicts: clang/docs/ReleaseNotes.rst clang/test/SemaCXX/decltype.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97646.
Still need to add tests.