Skip to content

[libc++][format] LWG4106: basic_format_args should not be default-constructible #97250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2024
Merged

[libc++][format] LWG4106: basic_format_args should not be default-constructible #97250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libcxx/docs/Status/Cxx2cIssues.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
"`4096 <https://wg21.link/LWG4096>`__","``views::iota(views::iota(0))`` should be rejected","St. Louis June 2024","","","|ranges|"
"`4098 <https://wg21.link/LWG4098>`__","``views::adjacent<0>`` should reject non-forward ranges","St. Louis June 2024","","","|ranges|"
"`4105 <https://wg21.link/LWG4105>`__","``ranges::ends_with``\`s Returns misses difference casting","St. Louis June 2024","","","|ranges|"
"`4106 <https://wg21.link/LWG4106>`__","``basic_format_args`` should not be default-constructible","St. Louis June 2024","","","|format|"
"`4106 <https://wg21.link/LWG4106>`__","``basic_format_args`` should not be default-constructible","St. Louis June 2024","|Complete|","19.0","|format|"
"","","","","",""
"`3343 <https://wg21.link/LWG3343>`__","Ordering of calls to ``unlock()`` and ``notify_all()`` in Effects element of ``notify_all_at_thread_exit()`` should be reversed","Not Yet Adopted","|Complete|","16.0",""
"XXXX","","The sys_info range should be affected by save","Not Yet Adopted","|Complete|","19.0"
Expand Down
2 changes: 0 additions & 2 deletions libcxx/include/__format/format_args.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ _LIBCPP_BEGIN_NAMESPACE_STD
template <class _Context>
class _LIBCPP_TEMPLATE_VIS basic_format_args {
public:
basic_format_args() noexcept = default;

template <class... _Args>
_LIBCPP_HIDE_FROM_ABI basic_format_args(const __format_arg_store<_Context, _Args...>& __store) noexcept
: __size_(sizeof...(_Args)) {
Expand Down
9 changes: 2 additions & 7 deletions libcxx/test/std/utilities/format/format.arguments/format.args/ctor.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@

// <format>

// basic_format_args() noexcept;
// template<class... Args>
// basic_format_args(const format-arg-store<Context, Args...>& store) noexcept;

#include <format>
#include <cassert>
#include <type_traits>

#include "test_macros.h"

Expand All @@ -24,12 +24,7 @@ void test() {
char c = 'c';
nullptr_t p = nullptr;
using Context = std::basic_format_context<CharT*, CharT>;
{
ASSERT_NOEXCEPT(std::basic_format_args<Context>{});

std::basic_format_args<Context> format_args{};
assert(!format_args.get(0));
}
static_assert(!std::is_default_constructible_v<std::basic_format_args<Context>>);
{
auto store = std::make_format_args<Context>(i);
ASSERT_NOEXCEPT(std::basic_format_args<Context>{store});
Expand Down
8 changes: 1 addition & 7 deletions libcxx/test/std/utilities/format/format.arguments/format.args/get.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,7 @@ void test_string_view(From value) {

template <class CharT>
void test() {
using Context = std::basic_format_context<CharT*, CharT>;
{
const std::basic_format_args<Context> format_args{};
ASSERT_NOEXCEPT(format_args.get(0));
assert(!format_args.get(0));
}

using Context = std::basic_format_context<CharT*, CharT>;
using char_type = typename Context::char_type;
std::basic_string<char_type> empty;
std::basic_string<char_type> str = MAKE_STRING(char_type, "abc");
Expand Down