[NFC][clang] Replace unreachable code in literal processing with assert #96579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address static verifier concerns about dead code in DoubleUnderscore check. Replace it with an assert.
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clang Author: Mike Rice (mikerice1969) ChangesAddress static verifier concerns about dead code in DoubleUnderscore check. Replace it with an assert. Full diff: https://github.com/llvm/llvm-project/pull/96579.diff 1 Files Affected:
diff --git a/clang/lib/Lex/LiteralSupport.cpp b/clang/lib/Lex/LiteralSupport.cpp
index 3df0391bdda77..9d2720af5dbd9 100644
--- a/clang/lib/Lex/LiteralSupport.cpp
+++ b/clang/lib/Lex/LiteralSupport.cpp
@@ -1123,8 +1123,9 @@ NumericLiteralParser::NumericLiteralParser(StringRef TokSpelling,
break; // Invalid for floats
if (HasSize)
break;
- if (DoubleUnderscore)
- break; // Cannot be repeated.
+ // There is currently no way to reach this with DoubleUnderscore set.
+ // If new double underscope literals are added handle it here as above.
+ assert(!DoubleUnderscore && "unhandled double underscore case");
if (LangOpts.CPlusPlus && s + 2 < ThisTokEnd &&
s[1] == '_') { // s + 2 < ThisTokEnd to ensure some character exists
// after __
|
AlexisPerry
pushed a commit
to llvm-project-tlp/llvm-project
that referenced
this pull request
Jul 9, 2024
…rt (llvm#96579) Address static verifier concerns about dead code in DoubleUnderscore check. Replace it with an assert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address static verifier concerns about dead code in DoubleUnderscore check. Replace it with an assert.