Skip to content

Conversation

mordante
Copy link
Member

This moves the files to libcxx/src/experimental/ as discussed in #90394.

Fixes: #94902

@mordante mordante requested a review from a team as a code owner June 15, 2024 12:35
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Jun 15, 2024
@llvmbot
Copy link
Member

llvmbot commented Jun 15, 2024

@llvm/pr-subscribers-libcxx

Author: Mark de Wever (mordante)

Changes

This moves the files to libcxx/src/experimental/ as discussed in #90394.

Fixes: #94902


Full diff: https://github.com/llvm/llvm-project/pull/95657.diff

9 Files Affected:

  • (modified) libcxx/src/CMakeLists.txt (+8-8)
  • (renamed) libcxx/src/experimental/chrono_exception.cpp ()
  • (renamed) libcxx/src/experimental/include/tzdb/time_zone_private.h ()
  • (renamed) libcxx/src/experimental/include/tzdb/types_private.h ()
  • (renamed) libcxx/src/experimental/include/tzdb/tzdb_list_private.h ()
  • (renamed) libcxx/src/experimental/include/tzdb/tzdb_private.h ()
  • (renamed) libcxx/src/experimental/time_zone.cpp ()
  • (renamed) libcxx/src/experimental/tzdb.cpp ()
  • (renamed) libcxx/src/experimental/tzdb_list.cpp ()
diff --git a/libcxx/src/CMakeLists.txt b/libcxx/src/CMakeLists.txt
index 9e6c70335a794..9453715636b44 100644
--- a/libcxx/src/CMakeLists.txt
+++ b/libcxx/src/CMakeLists.txt
@@ -336,16 +336,16 @@ endif()
 
 if (LIBCXX_ENABLE_LOCALIZATION AND LIBCXX_ENABLE_FILESYSTEM AND LIBCXX_ENABLE_TIME_ZONE_DATABASE)
   list(APPEND LIBCXX_EXPERIMENTAL_SOURCES
-    include/tzdb/time_zone_private.h
-    include/tzdb/types_private.h
-    include/tzdb/tzdb_list_private.h
-    include/tzdb/tzdb_private.h
+    experimental/include/tzdb/time_zone_private.h
+    experimental/include/tzdb/types_private.h
+    experimental/include/tzdb/tzdb_list_private.h
+    experimental/include/tzdb/tzdb_private.h
     # TODO TZDB The exception could be moved in chrono once the TZDB library
     # is no longer experimental.
-    chrono_exception.cpp
-    time_zone.cpp
-    tzdb.cpp
-    tzdb_list.cpp
+    experimental/chrono_exception.cpp
+    experimental/time_zone.cpp
+    experimental/tzdb.cpp
+    experimental/tzdb_list.cpp
     )
 endif()
 
diff --git a/libcxx/src/chrono_exception.cpp b/libcxx/src/experimental/chrono_exception.cpp
similarity index 100%
rename from libcxx/src/chrono_exception.cpp
rename to libcxx/src/experimental/chrono_exception.cpp
diff --git a/libcxx/src/include/tzdb/time_zone_private.h b/libcxx/src/experimental/include/tzdb/time_zone_private.h
similarity index 100%
rename from libcxx/src/include/tzdb/time_zone_private.h
rename to libcxx/src/experimental/include/tzdb/time_zone_private.h
diff --git a/libcxx/src/include/tzdb/types_private.h b/libcxx/src/experimental/include/tzdb/types_private.h
similarity index 100%
rename from libcxx/src/include/tzdb/types_private.h
rename to libcxx/src/experimental/include/tzdb/types_private.h
diff --git a/libcxx/src/include/tzdb/tzdb_list_private.h b/libcxx/src/experimental/include/tzdb/tzdb_list_private.h
similarity index 100%
rename from libcxx/src/include/tzdb/tzdb_list_private.h
rename to libcxx/src/experimental/include/tzdb/tzdb_list_private.h
diff --git a/libcxx/src/include/tzdb/tzdb_private.h b/libcxx/src/experimental/include/tzdb/tzdb_private.h
similarity index 100%
rename from libcxx/src/include/tzdb/tzdb_private.h
rename to libcxx/src/experimental/include/tzdb/tzdb_private.h
diff --git a/libcxx/src/time_zone.cpp b/libcxx/src/experimental/time_zone.cpp
similarity index 100%
rename from libcxx/src/time_zone.cpp
rename to libcxx/src/experimental/time_zone.cpp
diff --git a/libcxx/src/tzdb.cpp b/libcxx/src/experimental/tzdb.cpp
similarity index 100%
rename from libcxx/src/tzdb.cpp
rename to libcxx/src/experimental/tzdb.cpp
diff --git a/libcxx/src/tzdb_list.cpp b/libcxx/src/experimental/tzdb_list.cpp
similarity index 100%
rename from libcxx/src/tzdb_list.cpp
rename to libcxx/src/experimental/tzdb_list.cpp

@mordante mordante force-pushed the review/renames_tzdb_files branch from c8e5438 to 5e08f6b Compare June 15, 2024 15:50
This moves the files to libcxx/src/experimental/ as discussed in llvm#90394.

Fixes: llvm#94902
@mordante mordante force-pushed the review/renames_tzdb_files branch from 5e08f6b to cbe55b4 Compare July 6, 2024 10:06
@mordante mordante merged commit 9d6b68b into llvm:main Jul 7, 2024
@mordante mordante deleted the review/renames_tzdb_files branch July 7, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move experimental TZDB source files to the experimental directory.
3 participants