[flang] cmake fix for FLANG_RUNTIME_F128_MATH_LIB build #93054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove an extra '-D' in the call to add_compile_definitions. The extra -D causes -D-DFLANG_RUNTIME_F128_MATH_LIB=libquadmath to appear in compile options which results in a compilation failure. This occurs only on systems using cmake versions 3.22.1 or 3.24.3. Using cmake 3.28.1 seems to automatically remove the duplicate -D. Fixes llvm#81971
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove an extra '-D' in the call to add_compile_definitions. The extra -D causes -D-DFLANG_RUNTIME_F128_MATH_LIB=libquadmath to appear in compile options which results in a compilation failure. This occurs only on systems using cmake versions 3.22.1 or 3.24.3. Using cmake 3.28.1 seems to automatically remove the duplicate -D.
Fixes #81971