[bazel] add bolt address translation header to Passes #93014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid circular dependency introduced in a9b6749
Contributor
Author
|
maybe there is a better way to go about that? |
rupprecht
approved these changes
May 22, 2024
Collaborator
rupprecht
left a comment
rupprecht
left a comment
There was a problem hiding this comment.
Circular deps should just be avoided in the first place: https://llvm.org/docs/CodingStandards.html#library-layering
But as a temporary thing to bring bazel buildkite back to green, this seems fine.
Contributor
Author
|
cc @jyknight |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid circular dependency introduced in a9b6749