Skip to content

[flang] Relax checking of dummy procedures under BIND(C) #92474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2024
Merged

[flang] Relax checking of dummy procedures under BIND(C) #92474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions flang/include/flang/Semantics/tools.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,8 +213,7 @@ inline bool IsCUDADeviceContext(const Scope *scope) {
}

inline bool HasCUDAAttr(const Symbol &sym) {
if (const auto *details{
sym.GetUltimate().detailsIf<semantics::ObjectEntityDetails>()}) {
if (const auto *details{sym.GetUltimate().detailsIf<ObjectEntityDetails>()}) {
if (details->cudaDataAttr()) {
return true;
}
Expand All @@ -224,17 +223,18 @@ inline bool HasCUDAAttr(const Symbol &sym) {

inline bool NeedCUDAAlloc(const Symbol &sym) {
bool inDeviceSubprogram{IsCUDADeviceContext(&sym.owner())};
if (Fortran::semantics::IsDummy(sym))
if (IsDummy(sym)) {
return false;
if (const auto *details{
sym.GetUltimate().detailsIf<semantics::ObjectEntityDetails>()}) {
}
if (const auto *details{sym.GetUltimate().detailsIf<ObjectEntityDetails>()}) {
if (details->cudaDataAttr() &&
(*details->cudaDataAttr() == common::CUDADataAttr::Device ||
*details->cudaDataAttr() == common::CUDADataAttr::Managed ||
*details->cudaDataAttr() == common::CUDADataAttr::Unified)) {
// Descriptor is allocated on host when in host context.
if (Fortran::semantics::IsAllocatable(sym))
if (IsAllocatable(sym)) {
return inDeviceSubprogram;
}
return true;
}
}
Expand All @@ -246,7 +246,7 @@ std::optional<common::CUDADataAttr> GetCUDADataAttr(const Symbol *);

// Return an error if a symbol is not accessible from a scope
std::optional<parser::MessageFormattedText> CheckAccessibleSymbol(
const semantics::Scope &, const Symbol &);
const Scope &, const Symbol &);

// Analysis of image control statements
bool IsImageControlStmt(const parser::ExecutableConstruct &);
Expand Down Expand Up @@ -706,14 +706,13 @@ inline const parser::Name *getDesignatorNameIfDataRef(
bool CouldBeDataPointerValuedFunction(const Symbol *);

template <typename R, typename T>
std::optional<R> GetConstExpr(
Fortran::semantics::SemanticsContext &semanticsContext, const T &x) {
using DefaultCharConstantType = Fortran::evaluate::Ascii;
if (const auto *expr{Fortran::semantics::GetExpr(semanticsContext, x)}) {
const auto foldExpr{Fortran::evaluate::Fold(
semanticsContext.foldingContext(), Fortran::common::Clone(*expr))};
std::optional<R> GetConstExpr(SemanticsContext &semanticsContext, const T &x) {
using DefaultCharConstantType = evaluate::Ascii;
if (const auto *expr{GetExpr(semanticsContext, x)}) {
const auto foldExpr{evaluate::Fold(
semanticsContext.foldingContext(), common::Clone(*expr))};
if constexpr (std::is_same_v<R, std::string>) {
return Fortran::evaluate::GetScalarConstantValue<DefaultCharConstantType>(
return evaluate::GetScalarConstantValue<DefaultCharConstantType>(
foldExpr);
}
}
Expand Down
Loading