[RISCV][NFC] Remove redundant test cases. #91324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR llvm#89727 added the two test cases to verify `.option arch` should only work when having -menable-experimental-extensions. And the test idea could be splitted to 1. When having menable-experimental-extensions, clang passes +experimental. 2. `.option arch` only enabled when +experimental enabled. And we already had the two kind of test.
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: Yeting Kuo (yetingk) ChangesPR #89727 added the two test cases to verify
And we already had the two kind of tests. Full diff: https://github.com/llvm/llvm-project/pull/91324.diff 2 Files Affected:
diff --git a/clang/test/Driver/riscv-option-arch.c b/clang/test/Driver/riscv-option-arch.c
deleted file mode 100644
index 9f0e037cd12e0..0000000000000
--- a/clang/test/Driver/riscv-option-arch.c
+++ /dev/null
@@ -1,8 +0,0 @@
-// REQUIRES: riscv-registered-target
-// RUN: %clang --target=riscv64 -menable-experimental-extensions -c -o /dev/null %s
-// RUN: ! %clang --target=riscv64 -c -o /dev/null %s 2>&1 | FileCheck -check-prefixes=CHECK-ERR %s
-
-void foo() {
- asm volatile (".option arch, +zicfiss");
- // CHECK-ERR: Unexpected experimental extensions.
-}
diff --git a/clang/test/Driver/riscv-option-arch.s b/clang/test/Driver/riscv-option-arch.s
deleted file mode 100644
index c4ca4aa459ce2..0000000000000
--- a/clang/test/Driver/riscv-option-arch.s
+++ /dev/null
@@ -1,6 +0,0 @@
-# REQUIRES: riscv-registered-target
-# RUN: %clang --target=riscv64 -menable-experimental-extensions -c -o /dev/null %s
-# RUN: ! %clang --target=riscv64 -c -o /dev/null %s 2>&1 | FileCheck -check-prefixes=CHECK-ERR %s
-
-.option arch, +zicfiss
-# CHECK-ERR: Unexpected experimental extensions.
|
Member
|
@llvm/pr-subscribers-backend-risc-v Author: Yeting Kuo (yetingk) ChangesPR #89727 added the two test cases to verify
And we already had the two kind of tests. Full diff: https://github.com/llvm/llvm-project/pull/91324.diff 2 Files Affected:
diff --git a/clang/test/Driver/riscv-option-arch.c b/clang/test/Driver/riscv-option-arch.c
deleted file mode 100644
index 9f0e037cd12e0..0000000000000
--- a/clang/test/Driver/riscv-option-arch.c
+++ /dev/null
@@ -1,8 +0,0 @@
-// REQUIRES: riscv-registered-target
-// RUN: %clang --target=riscv64 -menable-experimental-extensions -c -o /dev/null %s
-// RUN: ! %clang --target=riscv64 -c -o /dev/null %s 2>&1 | FileCheck -check-prefixes=CHECK-ERR %s
-
-void foo() {
- asm volatile (".option arch, +zicfiss");
- // CHECK-ERR: Unexpected experimental extensions.
-}
diff --git a/clang/test/Driver/riscv-option-arch.s b/clang/test/Driver/riscv-option-arch.s
deleted file mode 100644
index c4ca4aa459ce2..0000000000000
--- a/clang/test/Driver/riscv-option-arch.s
+++ /dev/null
@@ -1,6 +0,0 @@
-# REQUIRES: riscv-registered-target
-# RUN: %clang --target=riscv64 -menable-experimental-extensions -c -o /dev/null %s
-# RUN: ! %clang --target=riscv64 -c -o /dev/null %s 2>&1 | FileCheck -check-prefixes=CHECK-ERR %s
-
-.option arch, +zicfiss
-# CHECK-ERR: Unexpected experimental extensions.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #89727 added the two test cases to verify
.option archshould only work when having -menable-experimental-extensions. And the test idea could be splitted to.option archonly enabled when +experimental enabled.And we already had the two kind of tests.