Disable test for lsan and x86_64h #90483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable this test on x86_64h for LSan. rdar://125052424
Member
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: None (thetruestblue) ChangesDisable this test on x86_64h for LSan. This test is failing with malformed object only on x86_64h. rdar://125052424 Full diff: https://github.com/llvm/llvm-project/pull/90483.diff 1 Files Affected:
diff --git a/compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_trace_pc_guard.cpp b/compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_trace_pc_guard.cpp
index ed817961c688cc..8e14eada6b9c45 100644
--- a/compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_trace_pc_guard.cpp
+++ b/compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_trace_pc_guard.cpp
@@ -2,6 +2,8 @@
// REQUIRES: has_sancovcc
// UNSUPPORTED: ubsan,i386-darwin,target={{(powerpc64|s390x|thumb).*}}
+// This test is failing for lsan on darwin on x86_64.
+// UNSUPPORTED: x86_64h && lsan
// XFAIL: tsan
// XFAIL: android && asan
|
yln
approved these changes
Apr 29, 2024
| // REQUIRES: has_sancovcc | ||
| // UNSUPPORTED: ubsan,i386-darwin,target={{(powerpc64|s390x|thumb).*}} | ||
| // This test is failing for lsan on darwin on x86_64. | ||
| // UNSUPPORTED: x86_64h && lsan |
Collaborator
There was a problem hiding this comment.
Would we want to constrain disablement to Apple platforms? ( && darwin)
Contributor
Author
There was a problem hiding this comment.
I believe the lit feature x86_64h is only added on Apple platforms. So I don't think the logic would actually add anything, though it would make it more clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable this test on x86_64h for LSan.
This test is failing with malformed object only on x86_64h.
Disabling for now.
rdar://125052424