[lldb-dap] Don't fail when SBProcess::GetMemoryRegionInfo returns error.

[ZequanWu]

SBProcess::GetMemoryRegionInfo uses qMemoryRegionInfo packet to get memory region info, but this is not supported in gdb-server and causing downstream lldb test failures. This change ignores the the error from SBProcess::GetMemoryRegionInfo .

Reported by @tedwoodward @jerinphilip.

[llvmbot]

@llvm/pr-subscribers-lldb

Author: Zequan Wu (ZequanWu)

Changes

SBProcess::GetMemoryRegionInfo uses qMemoryRegionInfo packet to get memory region info, but this is not supported in gdb-server and causing downstream lldb test failures. This change ignores the the error from SBProcess::GetMemoryRegionInfo .

Reported by @tedwoodward @jerinphilip.

---

Full diff: https://github.com/llvm/llvm-project/pull/87649.diff

1 Files Affected:

• (modified) lldb/tools/lldb-dap/lldb-dap.cpp (+15-19)

diff --git a/lldb/tools/lldb-dap/lldb-dap.cpp b/lldb/tools/lldb-dap/lldb-dap.cpp
index 55f8c920e60016..4b1b328c1bd561 100644
--- a/lldb/tools/lldb-dap/lldb-dap.cpp
+++ b/lldb/tools/lldb-dap/lldb-dap.cpp
@@ -2769,32 +2769,28 @@ void request_dataBreakpointInfo(const llvm::json::Object &request) {
                                           : "evaluation failed");
     } else {
       uint64_t load_addr = value.GetValueAsUnsigned();
-      addr = llvm::utohexstr(load_addr);
-      lldb::SBMemoryRegionInfo region;
-      lldb::SBError err =
-          g_dap.target.GetProcess().GetMemoryRegionInfo(load_addr, region);
-      if (err.Success()) {
-        if (!(region.IsReadable() || region.IsWritable())) {
-          body.try_emplace("dataId", nullptr);
-          body.try_emplace("description",
-                           "memory region for address " + addr +
-                               " has no read or write permissions");
-        } else {
-          lldb::SBData data = value.GetPointeeData();
-          if (data.IsValid())
-            size = llvm::utostr(data.GetByteSize());
-          else {
+      lldb::SBData data = value.GetPointeeData();
+      if (data.IsValid()) {
+        size = llvm::utostr(data.GetByteSize());
+        addr = llvm::utohexstr(load_addr);
+        lldb::SBMemoryRegionInfo region;
+        lldb::SBError err =
+            g_dap.target.GetProcess().GetMemoryRegionInfo(load_addr, region);
+        // Only lldb-server supports "qMemoryRegionInfo". So, don't fail this
+        // request if SBProcess::GetMemoryRegionInfo returns error.
+        if (err.Success()) {
+          if (!(region.IsReadable() || region.IsWritable())) {
             body.try_emplace("dataId", nullptr);
             body.try_emplace("description",
-                             "unable to get byte size for expression: " +
-                                 name.str());
+                             "memory region for address " + addr +
+                                 " has no read or write permissions");
           }
         }
       } else {
         body.try_emplace("dataId", nullptr);
         body.try_emplace("description",
-                         "unable to get memory region info for address " +
-                             addr);
+                         "unable to get byte size for expression: " +
+                             name.str());
       }
     }
   } else {

[ZequanWu]

Ping.

[walter-erquinigo]

makes sense to me