Skip to content

[tsan] Process SIGPROF as sync signal only if thread is alive #86343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 22, 2024
Merged

[tsan] Process SIGPROF as sync signal only if thread is alive #86343

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a01b823
[𝘀𝗽𝗿] changes to main this commit is based on
vitalybuka Mar 22, 2024
c8fc6d9
[𝘀𝗽𝗿] initial version
vitalybuka Mar 22, 2024
b53db38
rebase
vitalybuka Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2169,8 +2169,7 @@ static bool is_sync_signal(ThreadSignalContext *sctx, int sig,
return false;
#endif
return sig == SIGSEGV || sig == SIGBUS || sig == SIGILL || sig == SIGTRAP ||
sig == SIGABRT || sig == SIGFPE || sig == SIGPIPE || sig == SIGSYS ||
sig == SIGPROF;
sig == SIGABRT || sig == SIGFPE || sig == SIGPIPE || sig == SIGSYS;
}

void sighandler(int sig, __sanitizer_siginfo *info, void *ctx) {
Expand All @@ -2181,7 +2180,8 @@ void sighandler(int sig, __sanitizer_siginfo *info, void *ctx) {
return;
}
// Don't mess with synchronous signals.
const bool sync = is_sync_signal(sctx, sig, info);
const bool sync = is_sync_signal(sctx, sig, info) ||
(sig == SIGPROF && thr->is_inited && !thr->is_dead);
if (sync ||
// If we are in blocking function, we can safely process it now
// (but check if we are in a recursive interceptor,
Expand Down