[NewPM] Add disable-passes command line option
#76714
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed there are some command line options to disable passes in `TargetPassConfig.cpp`, this patch adds a unified option to disable them.
|
There should be another option like |
|
The arbitrary flags in TargetPassConfig are for passes and collections of passes which can be disabled. There are lots of passes which can't meaningfully be disabled. Exposing an option to disable arbitrary passes increases the bug surface |
|
Close for now, will reopen if find a better solution in future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed there are some command line options to disable passes in
TargetPassConfig.cpp, this patch adds a unified option to disable them. This option may be rarely used in tools likeopt, butllccould benefit from it.