[PowerPC] Expand FSINCOS of fp128 #76494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecnelises
requested review from
bzEq,
chenzheng1030,
orcguru,
EsmeYi,
lei137 and
stefanp-synopsys
| ; CHECK-NEXT: mflr r0 | ||
| ; CHECK-NEXT: stdu r1, -64(r1) | ||
| ; CHECK-NEXT: std r0, 80(r1) | ||
| ; CHECK-NEXT: .cfi_def_cfa_offset 64 |
There was a problem hiding this comment.
nit: remove these unnecessary cfi pseudo instructions.
| @@ -1176,6 +1176,7 @@ PPCTargetLowering::PPCTargetLowering(const PPCTargetMachine &TM, | |||
| setTruncStoreAction(MVT::f128, MVT::f32, Expand); | |||
|
|
|||
| // No implementation for these ops for PowerPC. | |||
| setOperationAction(ISD::FSINCOS, MVT::f128, Expand); | |||
There was a problem hiding this comment.
Have you checked other math related ISD nodes? Are MVT::f128 correctly handled for them?
There was a problem hiding this comment.
Yes, according to https://en.cppreference.com/w/c/numeric/math and nodes defined in ISDOpcodes.h. (they were already tested in f128-arith/round/fma.ll)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76442