Skip to content

Conversation

@hanhanW
Copy link
Contributor

@hanhanW hanhanW commented Dec 20, 2023

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Dec 20, 2023

@llvm/pr-subscribers-mlir

Author: Han-Chung Wang (hanhanW)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/76109.diff

1 Files Affected:

  • (modified) mlir/lib/Dialect/Tensor/IR/TensorOps.cpp (+2-2)
diff --git a/mlir/lib/Dialect/Tensor/IR/TensorOps.cpp b/mlir/lib/Dialect/Tensor/IR/TensorOps.cpp
index 1b0cdbd0f4f739..7c35dd4d953619 100644
--- a/mlir/lib/Dialect/Tensor/IR/TensorOps.cpp
+++ b/mlir/lib/Dialect/Tensor/IR/TensorOps.cpp
@@ -3469,7 +3469,7 @@ OpFoldResult SplatOp::fold(FoldAdaptor adaptor) {
 namespace {
 
 /// Packing one-dimensional tensor can be expressed as an expand shape op.
-struct SimplifyPackToExandShape : public OpRewritePattern<PackOp> {
+struct SimplifyPackToExpandShape : public OpRewritePattern<PackOp> {
   using OpRewritePattern<PackOp>::OpRewritePattern;
 
   Value insertExpand(RewriterBase &rewriter, Location loc, Value operand,
@@ -3501,7 +3501,7 @@ struct SimplifyPackToExandShape : public OpRewritePattern<PackOp> {
 } // namespace
 
 void mlir::tensor::populateSimplifyTensorPack(RewritePatternSet &patterns) {
-  patterns.add<SimplifyPackToExandShape>(patterns.getContext());
+  patterns.add<SimplifyPackToExpandShape>(patterns.getContext());
 }
 
 template <typename OpTy>

@llvmbot
Copy link
Member

llvmbot commented Dec 20, 2023

@llvm/pr-subscribers-mlir-tensor

Author: Han-Chung Wang (hanhanW)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/76109.diff

1 Files Affected:

  • (modified) mlir/lib/Dialect/Tensor/IR/TensorOps.cpp (+2-2)
diff --git a/mlir/lib/Dialect/Tensor/IR/TensorOps.cpp b/mlir/lib/Dialect/Tensor/IR/TensorOps.cpp
index 1b0cdbd0f4f739..7c35dd4d953619 100644
--- a/mlir/lib/Dialect/Tensor/IR/TensorOps.cpp
+++ b/mlir/lib/Dialect/Tensor/IR/TensorOps.cpp
@@ -3469,7 +3469,7 @@ OpFoldResult SplatOp::fold(FoldAdaptor adaptor) {
 namespace {
 
 /// Packing one-dimensional tensor can be expressed as an expand shape op.
-struct SimplifyPackToExandShape : public OpRewritePattern<PackOp> {
+struct SimplifyPackToExpandShape : public OpRewritePattern<PackOp> {
   using OpRewritePattern<PackOp>::OpRewritePattern;
 
   Value insertExpand(RewriterBase &rewriter, Location loc, Value operand,
@@ -3501,7 +3501,7 @@ struct SimplifyPackToExandShape : public OpRewritePattern<PackOp> {
 } // namespace
 
 void mlir::tensor::populateSimplifyTensorPack(RewritePatternSet &patterns) {
-  patterns.add<SimplifyPackToExandShape>(patterns.getContext());
+  patterns.add<SimplifyPackToExpandShape>(patterns.getContext());
 }
 
 template <typename OpTy>

@hanhanW hanhanW changed the title [mlir][tensor][NFC] Fix typos in pattern names. [mlir][tensor][NFC] Fix a typo in pack op simplification pattern names. Dec 20, 2023
@hanhanW hanhanW changed the title [mlir][tensor][NFC] Fix a typo in pack op simplification pattern names. [mlir][tensor][NFC] Fix a typo in pack simplification pattern. Dec 20, 2023
@hanhanW hanhanW merged commit bffdde8 into llvm:main Dec 21, 2023
@hanhanW hanhanW deleted the typo branch December 21, 2023 01:03
@chelini
Copy link
Contributor

chelini commented Dec 21, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants