Skip to content

PR#72453 : Exceeding maximum file name length #72654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 14, 2024
Merged

PR#72453 : Exceeding maximum file name length #72654

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b6bfb18
TESTING infra
shahidiqbal13 Nov 16, 2023
ddd7bb1
Merge branch 'llvm:main' into main
shahidiqbal13 Nov 17, 2023
7662d4f
PR#72453 : Exceeding maximum file name length
shahidiqbal13 Nov 17, 2023
d3d33e5
Reverted the earlier test text
shahidiqbal13 Nov 17, 2023
41c19e2
Code refactoring
shahidiqbal13 Nov 17, 2023
74f8c4e
Updated fix
shahidiqbal13 Nov 18, 2023
3945cf9
Updated fix with set as DS
shahidiqbal13 Nov 20, 2023
f6ecae5
updated , removed earlier check
shahidiqbal13 Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions llvm/include/llvm/Analysis/DOTGraphTraitsPass.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@
#include "llvm/Analysis/CFGPrinter.h"
#include "llvm/Support/FileSystem.h"
#include "llvm/Support/GraphWriter.h"
#include <unordered_set>

static std::unordered_set<std::string> nameObj;

namespace llvm {

Expand Down Expand Up @@ -83,10 +86,28 @@ struct DOTGraphTraitsViewer
StringRef Name;
};

static void shortenFileName(std::string &FN, unsigned char len = 250) {

FN = FN.substr(0, len);

auto strLen = FN.length();
while (strLen > 0) {
if (auto it = nameObj.find(FN); it != nameObj.end()) {
FN = FN.substr(0, --len);
} else {
nameObj.insert(FN);
break;
}
strLen--;
}
}

template <typename GraphT>
void printGraphForFunction(Function &F, GraphT Graph, StringRef Name,
bool IsSimple) {
std::string Filename = Name.str() + "." + F.getName().str() + ".dot";
std::string Filename = Name.str() + "." + F.getName().str();
shortenFileName(Filename);
Filename = Filename + ".dot";
std::error_code EC;

errs() << "Writing '" << Filename << "'...";
Expand Down Expand Up @@ -272,6 +293,7 @@ class DOTGraphTraitsModulePrinterWrapperPass : public ModulePass {

bool runOnModule(Module &M) override {
GraphT Graph = AnalysisGraphTraitsT::getGraph(&getAnalysis<AnalysisT>());
shortenFileName(Name);
std::string Filename = Name + ".dot";
std::error_code EC;

Expand Down Expand Up @@ -301,7 +323,9 @@ class DOTGraphTraitsModulePrinterWrapperPass : public ModulePass {
template <typename GraphT>
void WriteDOTGraphToFile(Function &F, GraphT &&Graph,
std::string FileNamePrefix, bool IsSimple) {
std::string Filename = FileNamePrefix + "." + F.getName().str() + ".dot";
std::string Filename = FileNamePrefix + "." + F.getName().str();
shortenFileName(Filename);
Filename = Filename + ".dot";
std::error_code EC;

errs() << "Writing '" << Filename << "'...";
Expand Down