[PowerPC][EarlyIfConversion] Do not insert isel if subtarget doesn't support isel
#72211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 14, 2023 06:11
bzEq
requested review from
amy-kwan,
chenzheng1030,
ecnelises,
nemanjai and
stefanp-synopsys
chenzheng1030
approved these changes
Nov 14, 2023
Collaborator
chenzheng1030
left a comment
chenzheng1030
left a comment
There was a problem hiding this comment.
LGTM. Thanks.
Please wait for some days in case other reviewers have comments.
sr-tream
pushed a commit
to sr-tream/llvm-project
that referenced
this pull request
Nov 20, 2023
…t support `isel` (llvm#72211) Some subtargets of PPC don't support `isel` instruction, early-ifcvt should not insert this instruction.
zahiraam
pushed a commit
to zahiraam/llvm-project
that referenced
this pull request
Nov 20, 2023
…t support `isel` (llvm#72211) Some subtargets of PPC don't support `isel` instruction, early-ifcvt should not insert this instruction.
Member
|
What problem is this solving? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some subtargets of PPC don't support
iselinstruction, early-ifcvt should not insert this instruction.