[RISCV] Add tests for vmadd for VP intrinsics. NFC #70042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have VP tests for vmacc but not vmadd. This copies the vmacc tests but swaps the false operand of vp.merge to be the multiplicand instead of the addend. This shows how we could fold the vmerge into the vmadd's mask if we commuted %a and %b.
preames
approved these changes
Oct 25, 2023
zahiraam
pushed a commit
to zahiraam/llvm-project
that referenced
this pull request
Oct 26, 2023
We have VP tests for vmacc but not vmadd. This copies the vmacc tests but swaps the false operand of vp.merge to be the multiplicand instead of the addend. This shows how we could fold the vmerge into the vmadd's mask if we commuted %a and %b.
lukel97
added a commit
to lukel97/llvm-project
that referenced
this pull request
Jun 13, 2025
This moves the peephole that folds vmerges into its operands into RISCVVectorPeephole. This will also allow us to eventually commute instructions to allow folding, see llvm#141885 and llvm#70042 Most of the test diffs are due to the slight change in instruction ordering. For now doPeepholeMaskedRVV is kept even though its a duplicate of RISCVVectorPeephole::convertToUnmasked to minimize the diff, I plan on removing it in a separate patch as it causes some instructions to be shuffled around. Similarly, this runs foldVMergeToMask before the other peepholes to minimize the diff for now. rvv-peephole-vmerge-vops-mir.ll was replaced with a dedicate vmerge-peephole.mir test.
lukel97
added a commit
that referenced
this pull request
Jul 4, 2025
) This moves the peephole that folds vmerges into its operands into RISCVVectorPeephole. This will also allow us to eventually commute instructions to allow folding, see #141885 and #70042 Most of the test diffs are due to the slight change in instruction ordering. For now doPeepholeMaskedRVV is kept even though its a duplicate of RISCVVectorPeephole::convertToUnmasked to minimize the diff, I plan on removing it in a separate patch as it causes some instructions to be shuffled around. Similarly, this runs foldVMergeToMask before the other peepholes to minimize the diff for now. rvv-peephole-vmerge-vops-mir.ll was replaced with a dedicated vmerge-peephole.mir test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have VP tests for vmacc but not vmadd. This copies the vmacc tests but swaps
the false operand of vp.merge to be the multiplicand instead of the addend.
This shows how we could fold the vmerge into the vmadd's mask if we commuted %a
and %b.