[NVPTX] Make i16x2 a native type and add supported vec instructions #65799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasRaoux
force-pushed
the
nvptx_i16x2_3
branch
from
1791485 to
2bd3ce7
Compare
Artem-B
reviewed
Sep 8, 2023
| ; COMMON: st.param.b32 [func_retval0+0], [[R]]; | ||
| ; COMMON: ret; | ||
| define <2 x half> @test_bitcast_2xi16_to_2xhalf(i16 %a) #0 { | ||
| %ins.0 = insertelement <2 x i16> undef, i16 %a, i32 0 |
Member
There was a problem hiding this comment.
I think we need similar constructs in the other bitcast tests, as the bitcast would otherwise just dropped.
I wonder if there's a better way to make sure we do end up lowering specifically bitcast.
Contributor
Author
There was a problem hiding this comment.
I think we need similar constructs in the other bitcast tests, as the bitcast would otherwise just dropped.
I wonder if there's a better way to make sure we do end up lowering specifically
bitcast.
good point, let me send another PR for those
thomasfaingnaert
pushed a commit
to thomasfaingnaert/llvm-project
that referenced
this pull request
Jan 15, 2024
…lvm#65799) recommit llvm#65432 with minor bug fix for bitcasts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recommit #65432 with minor bug fix for bitcasts