Skip to content

Conversation

@shiltian
Copy link
Contributor

@shiltian shiltian commented Sep 6, 2023

This patch enables AAAddressSpace for OpenMPOpt, though it only works
for load and store instructions.

This patch enables `AAAddressSpace` for OpenMPOpt, though it only works
for load and store instructions.
@shiltian shiltian requested a review from a team as a code owner September 6, 2023 22:48
@shiltian shiltian requested a review from jdoerfert September 6, 2023 22:49
Copy link
Member

@jdoerfert jdoerfert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@jplehr
Copy link
Contributor

jplehr commented Sep 7, 2023

Will this have an impact on runtime of OpenMPOpt and if so, do we already have an idea of how large that is?

@shiltian
Copy link
Contributor Author

shiltian commented Sep 7, 2023

Will this have an impact on runtime of OpenMPOpt and if so, do we already have an idea of how large that is?

It will not impact the runtime too much because the AA (for now) only depends on AAUnderlyingObjects, which I believe in most cases have already been created regardless.

@shiltian shiltian merged commit e91e3cf into llvm:main Sep 7, 2023
@shiltian shiltian deleted the as-omp branch September 7, 2023 16:24
@shiltian
Copy link
Contributor Author

shiltian commented Sep 7, 2023

It seems like the revert button here doesn't work…

shiltian added a commit that referenced this pull request Sep 7, 2023
This reverts commit e91e3cf because
AMD BB is not happy with it.
@shiltian shiltian restored the as-omp branch September 7, 2023 16:32
shiltian added a commit that referenced this pull request Sep 8, 2023
shiltian added a commit that referenced this pull request Sep 8, 2023
avillega pushed a commit to avillega/llvm-project that referenced this pull request Sep 11, 2023
avillega pushed a commit to avillega/llvm-project that referenced this pull request Sep 11, 2023
This reverts commit e91e3cf because
AMD BB is not happy with it.
@shiltian shiltian deleted the as-omp branch August 15, 2024 01:36
shiltian added a commit that referenced this pull request Aug 15, 2024
shiltian added a commit that referenced this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants