[libc] Fix vendor implemented math functions not being exported #65510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: A previous introduced a new object type for the GPU functions implemented by an external vendor library. This was done so they we did not attempt to run tests on functions which we did not implement, however this accidentally stopped them from being included in the actual output. Fix this by checking the new type as well. The long term goal is to remove this vendor handling altogether, but is being used as a short-term solution to provide a math library on the GPU which currently lacks one.
sivachandra
approved these changes
Sep 6, 2023
avillega
pushed a commit
to avillega/llvm-project
that referenced
this pull request
Sep 11, 2023
…#65510) Summary: A previous introduced a new object type for the GPU functions implemented by an external vendor library. This was done so they we did not attempt to run tests on functions which we did not implement, however this accidentally stopped them from being included in the actual output. Fix this by checking the new type as well. The long term goal is to remove this vendor handling altogether, but is being used as a short-term solution to provide a math library on the GPU which currently lacks one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
A previous introduced a new object type for the GPU functions
implemented by an external vendor library. This was done so they we did
not attempt to run tests on functions which we did not implement,
however this accidentally stopped them from being included in the actual
output. Fix this by checking the new type as well.
The long term goal is to remove this vendor handling altogether, but is
being used as a short-term solution to provide a math library on the
GPU which currently lacks one.