[mlir] Make classof substitution in interface use an instance
#65492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joker-eph
approved these changes
Sep 7, 2023
Collaborator
joker-eph
left a comment
joker-eph
left a comment
There was a problem hiding this comment.
Can there be a test for this?
jpienaar
approved these changes
Sep 7, 2023
The substitution supported by `extraClassOf` is currently limited to only the base instance, i.e. `Operation*`, `Type` or `Attribute`, which limits the kind of checks you can perform in the `classof` implementation. Since prior to the user code, the interface concept is fetched, we can use it to construct an instance of the interface, allowing use of its methods in the `classof` check. Since an instance of the interface allows access to the base class methods through the `->` operator, I've gone ahead and replaced the substitution of `$_op/$_type/$_attr` with an interface instance. This is also consistent with `extraSharedClassDeclaration` and other methods created in the interface class which do the same.
zero9178
force-pushed
the
classof-interface-substitution
branch
from
29158fb to
2f40679
Compare
avillega
pushed a commit
to avillega/llvm-project
that referenced
this pull request
Sep 11, 2023
…#65492) The substitution supported by `extraClassOf` is currently limited to only the base instance, i.e. `Operation*`, `Type` or `Attribute`, which limits the kind of checks you can perform in the `classof` implementation. Since prior to the user code, the interface concept is fetched, we can use it to construct an instance of the interface, allowing use of its methods in the `classof` check. Since an instance of the interface allows access to the base class methods through the `->` operator, I've gone ahead and replaced the substitution of `$_op/$_type/$_attr` with an interface instance. This is also consistent with `extraSharedClassDeclaration` and other methods created in the interface class which do the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The substitution supported by
extraClassOfis currently limited to only the base instance, i.e.Operation*,TypeorAttribute, which limits the kind of checks you can perform in theclassofimplementation.Since prior to the user code, the interface concept is fetched, we can use it to construct an instance of the interface, allowing use of its methods in the
classofcheck.Since an instance of the interface allows access to the base class methods through the
->operator, I've gone ahead and replaced the substitution of$_op/$_type/$_attrwith an interface instance. This is also consistent withextraSharedClassDeclarationand other methods created in the interface class which do the same.