[clang][MSExtentions] Fix invalid overload failure about the loss of __unaligned qualifier
#65248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`__unaligned` qualifier Loss of `__unaligned` qualifier does not invalidate overload candidates. This fixes a regression reported in https://reviews.llvm.org/D153690
hazohelet
added
the
clang:frontend
Contributor
|
Looks good to me but can you add a release note? |
cor3ntin
approved these changes
Sep 5, 2023
AaronBallman
approved these changes
Sep 5, 2023
Collaborator
AaronBallman
left a comment
AaronBallman
left a comment
There was a problem hiding this comment.
LGTM; I think this can be held out of 17.0.0 but would be fine to backport to a later 17.x release if desired.
qihangkong
pushed a commit
to rvgpu/llvm
that referenced
this pull request
Apr 18, 2024
…`__unaligned` qualifier (#65248) Loss of `__unaligned` qualifier does not invalidate overload candidates. This fixes a regression reported in https://reviews.llvm.org/D153690 Reviewed By: cor3ntin, AaronBallman PR: llvm/llvm-project#65248
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loss of
__unalignedqualifier does not invalidate overload candidates.This fixes a regression reported in https://reviews.llvm.org/D153690