[OpenACC] add cl::values to ACCImplicitRoutineOptions

[rscottmanley]

Add the cl::values to the pass options so an assert is not reached when trying to generate a reproducer e.g. "unknown data value for option"

[llvmbot]

@llvm/pr-subscribers-mlir-openacc

@llvm/pr-subscribers-mlir

Author: Scott Manley (rscottmanley)

Changes

Add the cl::values to the pass options so an assert is not reached when trying to generate a reproducer e.g. "unknown data value for option"

---

Full diff: https://github.com/llvm/llvm-project/pull/168601.diff

1 Files Affected:

• (modified) mlir/include/mlir/Dialect/OpenACC/Transforms/Passes.td (+10-1)

diff --git a/mlir/include/mlir/Dialect/OpenACC/Transforms/Passes.td b/mlir/include/mlir/Dialect/OpenACC/Transforms/Passes.td
index 970d9304d8289..0b11f144f9014 100644
--- a/mlir/include/mlir/Dialect/OpenACC/Transforms/Passes.td
+++ b/mlir/include/mlir/Dialect/OpenACC/Transforms/Passes.td
@@ -97,7 +97,16 @@ def ACCImplicitRoutine : Pass<"acc-implicit-routine", "mlir::ModuleOp"> {
            "mlir::acc::DeviceType::None",
            "Target device type for implicit routine generation. "
            "Ensures that `acc routine` device_type clauses are "
-           "properly considered not just default clauses.">
+           "properly considered not just default clauses.",
+           [{::llvm::cl::values(
+              clEnumValN(mlir::acc::DeviceType::None, "none", "none"),
+              clEnumValN(mlir::acc::DeviceType::Star, "*", "*"),
+              clEnumValN(mlir::acc::DeviceType::Default, "default", "default"),
+              clEnumValN(mlir::acc::DeviceType::Host, "host", "host"),
+              clEnumValN(mlir::acc::DeviceType::Multicore, "multicore", "multicore"),
+              clEnumValN(mlir::acc::DeviceType::Nvidia, "nvidia", "nvidia"),
+              clEnumValN(mlir::acc::DeviceType::Radeon, "radeon", "radeon"))
+           }]>
   ];
 }
 

[razvanlupusoru]

Thank you!

[github-actions]

🐧 Linux x64 Test Results

• 7083 tests passed
• 594 tests skipped